github · brave-search-mcp-serverHEAD

Evidence

import { randomUUID } from 'node:crypto';

import express, { type Request, type Response } from 'express';

import config from '../config.js';

import createMcpServer from '../server.js';

import { StreamableHTTPServerTransport } from '@modelcontextprotocol/sdk/server/streamableHttp.js';

import { ListToolsRequest, ListToolsRequestSchema } from '@modelcontextprotocol/sdk/types.js';

const yieldGenericServerError = (res: Response) => {

  res.status(500).json({

    id: null,

    jsonrpc: '2.0',

    err

Remediation

Apply auth middleware at the route or router level: - Express / Fastify / Koa: `passport.authenticate(...)`, `requireAuth`, `verifyToken`, or an equivalent JWT middleware applied via `router.use(authMw)` or as a per-route handler. - FastAPI: `Depends(get_current_user)`, `OAuth2PasswordBearer`, `HTTPBearer`, or `verify_jwt` dependency. - Flask: `@login_required`, `@auth_required`, `@jwt_required`, or call `verify_jwt_in_request()` in the handler. Mounting MCP behind a s

Evidence

headers.set(key, String(value));

  }

  const response = await fetch(urlWithParams, { headers });

  // Handle Error

  if (!response.ok) {

Remediation

Pass timeout= on every call: - HTTP: `requests.get(url, timeout=5)`, `httpx.get(url, timeout=5.0)` - Node fetch: `AbortSignal.timeout(5000)` - Subprocess: `subprocess.run(["cmd"], timeout=30, check=True)` Pick a value short enough to fail fast and retry.

Evidence

const ResultSchema = z.looseObject({

  title: z.string().describe('The display title of the location.'),

  url: z.string().describe('Primary URL associated with the location.'),

  is_source_local: z.boolean().optional(),

  is_source_both: z.boolean().optional(),

  description: z

Remediation

Shape the schema to the tool's actual intent: - Zod: chain `.enum([...])`, `.regex(/.../)`, or `.max(n)`; prefer `z.enum([...])` or `z.literal(...)` when the value set is small. - Pydantic: use `Literal["a", "b"]` or `Field(max_length=..., pattern=r"...")`. - JSON Schema: add `"enum"`, `"pattern"`, or `"maxLength"` to the property. An overbroad schema is an "overpowered tool" — the model has nothing to prevent it from calling the tool with input far beyond what the tool's prose contract

Evidence

netloc: z.string().optional().describe('The network location of the URL.'),

  hostname: z.string().optional().describe('The lowercased hostname of the URL.'),

  favicon: z.url().optional().describe('The URL of the favicon of the URL.'),

  path: z.string().optional().describe('The path of the URL (useful as a display string).'),

});

export const ConfidenceSchema = z

Remediation

Shape the schema to the tool's actual intent: - Zod: chain `.enum([...])`, `.regex(/.../)`, or `.max(n)`; prefer `z.enum([...])` or `z.literal(...)` when the value set is small. - Pydantic: use `Literal["a", "b"]` or `Field(max_length=..., pattern=r"...")`. - JSON Schema: add `"enum"`, `"pattern"`, or `"maxLength"` to the property. An overbroad schema is an "overpowered tool" — the model has nothing to prevent it from calling the tool with input far beyond what the tool's prose contract

Evidence

const ActionSchema = z.looseObject({

  type: z.string().describe('The type representing the action.'),

  url: z.string().describe('A URL representing the action to be taken.'),

});

const MetaUrlSchema = z.looseObject({

Remediation

Shape the schema to the tool's actual intent: - Zod: chain `.enum([...])`, `.regex(/.../)`, or `.max(n)`; prefer `z.enum([...])` or `z.literal(...)` when the value set is small. - Pydantic: use `Literal["a", "b"]` or `Field(max_length=..., pattern=r"...")`. - JSON Schema: add `"enum"`, `"pattern"`, or `"maxLength"` to the property. An overbroad schema is an "overpowered tool" — the model has nothing to prevent it from calling the tool with input far beyond what the tool's prose contract

Evidence

const ResultsSchema = z.looseObject({

  title: z.string().describe('The display title of the location.'),

  url: z.string().describe('Primary URL associated with the location.'),

  is_source_local: z.boolean().optional(),

  is_source_both: z.boolean().optional(),

  description: z

Remediation

Shape the schema to the tool's actual intent: - Zod: chain `.enum([...])`, `.regex(/.../)`, or `.max(n)`; prefer `z.enum([...])` or `z.literal(...)` when the value set is small. - Pydantic: use `Literal["a", "b"]` or `Field(max_length=..., pattern=r"...")`. - JSON Schema: add `"enum"`, `"pattern"`, or `"maxLength"` to the property. An overbroad schema is an "overpowered tool" — the model has nothing to prevent it from calling the tool with input far beyond what the tool's prose contract

Evidence

type: z.string().optional(),

  name: z.string().optional(),

  long_name: z.string().optional(),

  url: z.string().optional(),

  img: z.string().optional(),

});

Remediation

Shape the schema to the tool's actual intent: - Zod: chain `.enum([...])`, `.regex(/.../)`, or `.max(n)`; prefer `z.enum([...])` or `z.literal(...)` when the value set is small. - Pydantic: use `Literal["a", "b"]` or `Field(max_length=..., pattern=r"...")`. - JSON Schema: add `"enum"`, `"pattern"`, or `"maxLength"` to the property. An overbroad schema is an "overpowered tool" — the model has nothing to prevent it from calling the tool with input far beyond what the tool's prose contract

Evidence

"build": "tsc && shx chmod +x dist/*.js",

    "smithery:build": "smithery build",

    "smithery:dev": "smithery dev",

    "prepare": "npm run format && npm run build",

    "watch": "tsc --watch",

    "format": "prettier --write \"src/**/*.ts\"",

    "format:check": "prettier --check \"src/**/*.ts\"",

Remediation

Prefer libraries that do not require install-time code execution: - Drop `postinstall`/`preinstall`/`prepare` scripts if the work can happen at runtime or build-time instead. - Ship pre-built native binaries rather than compiling via a custom `cmdclass` or `build_ext` override. - For Dockerfiles: replace `RUN curl … | sh` with a pinned download + checksum verification + explicit `RUN` of a named script. - If the hook is unavoidable, document exactly what it does so downstream reviewers